Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fallback for pow #5919

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Don't fallback for pow #5919

merged 2 commits into from
Nov 29, 2023

Conversation

qihqi
Copy link
Collaborator

@qihqi qihqi commented Nov 22, 2023

No description provided.

@JackCaoG
Copy link
Collaborator

op info test started to complain, can you take a look?

@@ -418,4 +419,5 @@ def test_reference_eager(self, device, dtype, op):
instantiate_device_type_tests(TestOpInfo, globals())

if __name__ == '__main__':
run_tests()
#run_tests()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, remove this

@@ -3295,6 +3295,29 @@ def test_aten_pow_Tensor_Scalar_2(self):
kwargs = dict()
run_export_and_compare(self, torch.ops.aten.pow.Tensor_Scalar, args, kwargs)

def test_aten_pow_Scalar_1(self):
args = (10000,
torch.Tensor([
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not using randn here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way works.

@qihqi qihqi merged commit 402166b into pytorch:master Nov 29, 2023
18 checks passed
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 1, 2023
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Dec 1, 2023
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* Don't fallback for pow
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* Don't fallback for pow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants